linux-kernel - Re: [PATCH] exec: make prepare_bprm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181210083049.GI1286@dhcp22.suse.cz>
Date:   Mon, 10 Dec 2018 09:30:49 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Chanho Min <chanho.min@....com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Seungho Park <seungho1.park@....com>
Subject: Re: [PATCH] exec: make prepare_bprm_creds static

On Mon 10-12-18 16:49:54, Chanho Min wrote:
> prepare_bprm_creds is not used outside exec.c, so there's no reason for it
> to have external linkage.
> 
> Signed-off-by: Chanho Min <chanho.min@....com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  fs/exec.c               | 2 +-
>  include/linux/binfmts.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index fc281b7..b6c9e5f 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1399,7 +1399,7 @@ EXPORT_SYMBOL(finalize_exec);
>   * Or, if exec fails before, free_bprm() should release ->cred and
>   * and unlock.
>   */
> -int prepare_bprm_creds(struct linux_binprm *bprm)
> +static int prepare_bprm_creds(struct linux_binprm *bprm)
>  {
>  	if (mutex_lock_interruptible(&current->signal->cred_guard_mutex))
>  		return -ERESTARTNOINTR;
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index e9f5fe6..6a9e43d 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -138,7 +138,6 @@ extern int transfer_args_to_stack(struct linux_binprm *bprm,
>  extern int bprm_change_interp(const char *interp, struct linux_binprm *bprm);
>  extern int copy_strings_kernel(int argc, const char *const *argv,
>  			       struct linux_binprm *bprm);
> -extern int prepare_bprm_creds(struct linux_binprm *bprm);
>  extern void install_exec_creds(struct linux_binprm *bprm);
>  extern void set_binfmt(struct linux_binfmt *new);
>  extern ssize_t read_code(struct file *, unsigned long, loff_t, size_t);
> -- 
> 2.1.4
> 

-- 
Michal Hocko
SUSE Labs