linux-kernel - Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 09:28:08 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
CC:     Lee Jones <lee.jones@...aro.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular

On Fri, Dec 07, 2018 at 03:11:03PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_WM8350_I2C
> drivers/mfd/Kconfig:    bool "Wolfson Microelectronics WM8350 with I2C"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
> 
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do delete an unused moduleparam.h
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: patches@...nsource.cirrus.com
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
> -static int wm8350_i2c_remove(struct i2c_client *i2c)
> -{
> -	struct wm8350 *wm8350 = i2c_get_clientdata(i2c);
> -
> -	wm8350_device_exit(wm8350);

This is the only caller of this function so you probably want to
remove it in the next patch as we did for the 831x stuff.

Thanks,
Charles