linux-kernel - Re: [PATCH] rtc: proc: printf using alarm for alrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6997a28d4752ce340638f3de5a655d4d@codeaurora.org>
Date:   Mon, 10 Dec 2018 18:01:23 +0800
From:   yuankuiz@...eaurora.org
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     a.zummo@...ertech.it, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc-owner@...r.kernel.org
Subject: Re: [PATCH] rtc: proc: printf using alarm for alrm

On 2018-12-07 04:38 AM, Alexandre Belloni wrote:
> On 06/12/2018 15:22:51+0800, yuankuiz@...eaurora.org wrote:
>> Hi,
>> 
>>     Kindly, this format change formats the rtc dump from:
>>         alrm_time	: 00:00:00
>>         alrm_date	: 1970-01-01
>>         alarm_IRQ	: no
>>         alrm_pending	: no
>> 
>>     to:
>>         alarm time	: 00:00:00
>>         alarm date	: 1970-01-01
>>         alarm IRQ	: no
>>         alarm pending	: no
>> 
> 
> Yes, and this would break the ABI as this file is in procfs. This is 
> not
> something I'm willing to do, especially since this file has been
> deprecated since 2006.

OK. So shall we default it as n like:
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a819ef0..c51f0e1 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -100,7 +100,7 @@ config RTC_INTF_SYSFS
  config RTC_INTF_PROC
         bool "/proc/driver/rtc (procfs for rtcN)"
         depends on PROC_FS
-       default RTC_CLASS
+       default n
         help
           Say yes here if you want to use your system clock RTC through
           the proc interface, /proc/driver/rtc.


     Thanks,
BR//John Zhao