linux-kernel - Re: [RESEND PATCH v2] clocksource/arm_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9303a6cf-24af-2f31-9fbd-8c1ecdd5e4f4@arm.com>
Date:   Mon, 10 Dec 2018 14:19:53 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Peter Zijlstra <peterz@...radead.org>, Qian Cai <cai@....pw>
Cc:     akpm@...ux-foundation.org, mark.rutland@....com,
        marc.zyngier@....com, daniel.lezcano@...aro.org,
        tglx@...utronix.de, mingo@...nel.org, longman@...hat.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] clocksource/arm_arch_timer: fix a lockdep
 warning

Hi,

On 10/12/2018 14:07, Peter Zijlstra wrote:
[...]
> ---
>  kernel/cpu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 91d5c38eb7e5..e1ee8caf28b5 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -313,6 +313,8 @@ void cpus_write_unlock(void)
>  
>  void lockdep_assert_cpus_held(void)
>  {
> +	if (system_state < SYSTEM_RUNNING)
> +		return;
>  	percpu_rwsem_assert_held(&cpu_hotplug_lock);
>  }
>  

Kinda hijacking the thread here - is that something we'd want to replace 

    40fa3780bac2 ("sched/core: Take the hotplug lock in sched_init_smp()")

with?