linux-kernel - Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce1442f3-357b-d647-958e-cc4a89282b79@kontron.de>
Date:   Mon, 10 Dec 2018 16:31:03 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        NXP Linux Team <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "boris.brezillon@...tlin.com" <boris.brezillon@...tlin.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver

Hi FSL/ARM maintainers,

On 10.12.18 17:26, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> We have prepared a new driver for the FSL QSPI controller that works under
> the SPI framework. The current devicetrees are broken because they use an
> inconsistent scheme for assigning the reg properties.
> 
> As, in contrast to the current driver, the new driver will use the reg
> properties to select the correct chip, we need to fix them.
> 
> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used
> and while at it clean up and remove some unused properties.

could you please consider these devicetree patches for v4.21?

We have the new FSL QSPI driver under the SPI framework ([1]) ready, but 
we need some small fixes to the devicetrees that are currently broken.

As the new driver depends on these changes (mainly the change to the reg 
properties) and it is not possible to add compatibility for the old 
bindings, it would be really nice to have them in v4.21, so we can queue 
the driver for v4.22 or whatever the next release will be called.

Please also see [2] for some more explanation.

Thanks,
Frieder

[1] https://patchwork.ozlabs.org/cover/1007641/
[2] https://patchwork.ozlabs.org/patch/922817/#1925445

> 
> Frieder Schrempf (5):
>    arm64: dts: Remove unused properties from FSL QSPI driver nodes
>    ARM: dts: Remove unused properties from FSL QSPI driver nodes
>    ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes
>    arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
>    ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller
> 
>   arch/arm/boot/dts/imx6sx-sdb-reva.dts              | 8 ++++++--
>   arch/arm/boot/dts/imx6sx-sdb.dts                   | 8 ++++++--
>   arch/arm/boot/dts/imx6ul-14x14-evk.dtsi            | 2 ++
>   arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts        | 5 ++---
>   arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts  | 3 ++-
>   arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts  | 4 ++--
>   arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 6 ++++--
>   arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++
>   8 files changed, 28 insertions(+), 12 deletions(-)
>