linux-kernel - Re: [PATCH] scripts/atomic: change 'fold' to 'grep'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181210175211.hqw4usnzh43a4kab@lakrids.cambridge.arm.com>
Date:   Mon, 10 Dec 2018 17:52:11 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Will Deacon <will.deacon@....com>,
        Anders Roxell <anders.roxell@...aro.org>, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/atomic: change 'fold' to 'grep'

Hi Ingo,

On Thu, Dec 06, 2018 at 05:15:28PM +0100, Ingo Molnar wrote:
> 
> * Will Deacon <will.deacon@....com> wrote:
> 
> > [+ Ingo and Mark]
> > 
> > On Tue, Dec 04, 2018 at 10:47:13PM +0100, Anders Roxell wrote:
> > > Some distibutions and build systems doesn't include 'fold' from
> > > coreutils default.
> > > 
> > > .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
> > > 
> > > Rework to use 'grep' instead of 'fold' to use a dependency that is
> > > already used a lot in the kernel.
> > > 
> > > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > > Suggested-by: Will Deacon <will.deacon@....com>
> > > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> > > ---
> > >  scripts/atomic/atomic-tbl.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> > > index 9d6be538a987..81d5c32039dd 100755
> > > --- a/scripts/atomic/atomic-tbl.sh
> > > +++ b/scripts/atomic/atomic-tbl.sh
> > > @@ -180,7 +180,7 @@ gen_proto_variants()
> > >  #gen_proto(meta, ...)
> > >  gen_proto() {
> > >  	local meta="$1"; shift
> > > -	for m in $(echo "${meta}" | fold -w1); do
> > > +	for m in $(echo "${meta}" | grep -o .); do
> > >  		gen_proto_variants "${m}" "$@"
> > >  	done
> > 
> > Acked-by: Will Deacon <will.deacon@....com>
> > 
> > Ingo -- please can you take this one via -tip?
> 
> I'm still waiting for a reply to my previous concerns expressed in:
> 
>    Re: [tip:locking/core] locking/atomics: Check generated headers are up-to-date
>    <20181128083057.GA7879@...il.com>
> 
> Will remove it from linux-next if there's no good resolution for this 
> cycle.

I've just sent a couple of patches for that; please see:

https://lkml.kernel.org/r/20181210175035.45096-1-mark.rutland@arm.com

Thanks,
Mark.