linux-kernel - Re: [PATCH] rcu: Print correct in print_one_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20181210180319.GU4170@linux.ibm.com>
Date:   Mon, 10 Dec 2018 10:03:19 -0800
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Liu Song <fishland@...yun.com>
Cc:     josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        linux-kernel@...r.kernel.org, liu.song11@....com.cn
Subject: Re: [PATCH] rcu: Print correct in print_one_rcu_pending

On Mon, Dec 10, 2018 at 11:35:56PM +0800, Liu Song wrote:
> My kernel version is 4.4.166 and I found incorrect print info
> from print_one_rcu_pending. Adjust the description to make the
> information correct.
> 
> Signed-off-by: Liu Song <liu.song11@....com.cn>

This does not apply to mainline because debugfs tracing has been removed.

Please do feel free to send it to -stable, though I have no idea what the
-stable folks do about fixes to things that are no longer in mainline.
In that case, it is clear that the rule about waiting until it gets to
mainline isn't appropriate.  ;-)

							Thanx, Paul

> ---
>  kernel/rcu/tree_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree_trace.c b/kernel/rcu/tree_trace.c
> index ef7093cc9b5c..5d0eddc9dc63 100644
> --- a/kernel/rcu/tree_trace.c
> +++ b/kernel/rcu/tree_trace.c
> @@ -365,7 +365,7 @@ static void print_one_rcu_pending(struct seq_file *m, struct rcu_data *rdp)
>  		   rdp->n_rp_report_qs,
>  		   rdp->n_rp_cb_ready,
>  		   rdp->n_rp_cpu_needs_gp);
> -	seq_printf(m, "gpc=%ld gps=%ld nn=%ld ndw%ld\n",
> +	seq_printf(m, "gpc=%ld gps=%ld ndw=%ld nn=%ld\n",
>  		   rdp->n_rp_gp_completed,
>  		   rdp->n_rp_gp_started,
>  		   rdp->n_rp_nocb_defer_wakeup,
> -- 
> 2.19.1
>