linux-kernel - Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181210200030.GC11670@windriver.com>
Date:   Mon, 10 Dec 2018 15:00:31 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
CC:     Lee Jones <lee.jones@...aro.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular

[Re: [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular] On 10/12/2018 (Mon 09:28) Charles Keepax wrote:

> On Fri, Dec 07, 2018 at 03:11:03PM -0500, Paul Gortmaker wrote:

[...]

> > -static int wm8350_i2c_remove(struct i2c_client *i2c)
> > -{
> > -	struct wm8350 *wm8350 = i2c_get_clientdata(i2c);
> > -
> > -	wm8350_device_exit(wm8350);
> 
> This is the only caller of this function so you probably want to
> remove it in the next patch as we did for the 831x stuff.

Thanks - I should have caught this instance after you pointed me at
the 831x version of the same issue.  But I did not.  :-(

I'll follow up the 17/18 wm8350-core patch with the wm8350_device_exit
delete added ; maybe if you can Ack that and hence the unchanged
wm8350-i2c patch shown here - then we can avoid me spamming Lee and
everyone else with 20-odd patches in v5 just to add acks to a v4 - vs.
hopefully having a v4 being final.

Linus - I'd removed your Ack from 831x-core and this pending 8350-core
update, since the original patch you ack'd has since changed to delete
an orphaned function.  I would of course add them back if you are OK
with the updated versions and put them in the v4, but I did not want to
assume that.

Acks will all be after SOB lines as requested by Lee in the v4 as well.

Thanks,
Paul.
--

> 
> Thanks, Charles