linux-kernel - Re: [PATCH v3 0/3] sh: system call table generation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 15:30:36 -0500
From:   Rich Felker <dalias@...c.org>
To:     Firoz Khan <firoz.khan@...aro.org>
Cc:     linux-sh@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v3 0/3] sh: system call table generation support

On Mon, Nov 19, 2018 at 10:38:20AM +0530, Firoz Khan wrote:
> On Wed, 14 Nov 2018 at 10:02, Firoz Khan <firoz.khan@...aro.org> wrote:
> >
> > The purpose of this patch series is, we can easily
> > add/modify/delete system call table support by cha-
> > nging entry in syscall.tbl file instead of manually
> > changing many files. The other goal is to unify the
> > system call table generation support implementation
> > across all the architectures.
> >
> > The system call tables are in different format in
> > all architecture. It will be difficult to manually
> > add, modify or delete the system calls in the resp-
> > ective files manually. To make it easy by keeping a
> > script and which'll generate uapi header file and
> > syscall table file.
> >
> > syscall.tbl contains the list of available system
> > calls along with system call number and correspond-
> > ing entry point. Add a new system call in this arch-
> > itecture will be possible by adding new entry in
> > the syscall.tbl file.
> >
> > Adding a new table entry consisting of:
> >         - System call number.
> >         - ABI.
> >         - System call name.
> >         - Entry point name.
> >
> > Please note, this support is only available for 32-bit
> > kernel, not 64-bit kernel. As I came across the 64-bit
> > kernel is not active for long time.
> >
> > ARM, s390 and x86 architecuture does exist the sim-
> > ilar support. I leverage their implementation to come
> > up with a generic solution.
> >
> > I have done the same support for work for alpha, ia64,
> > m68k, microblaze, mips, parisc, powerpc, sparc, and
> > xtensa. Below mentioned git repository contains more
> > details about the workflow.
> >
> > https://github.com/frzkhn/system_call_table_generator/
> >
> > Finally, this is the ground work to solve the Y2038
> > issue. We need to add two dozen of system calls to solve
> > Y2038 issue. So this patch series will help to add new
> > system calls easily by adding new entry in the syscall-
> > .tbl.
> >
> > Changes since v2:
> >  - changed from generic-y to generated-y in Kbuild.
> >
> > Changes since v1:
> >  - optimized/updated the syscall table generation
> >    scripts.
> >  - fixed all mixed indentation issues in syscall.tbl.
> >  - added "comments" in syscall.tbl.
> >
> > Firoz Khan (3):
> >   sh: add __NR_syscalls along with NR_syscalls
> >   sh: add system call table generation support
> >   sh: generate uapi header and syscall table header files
> 
> Gentle reminder!
> 
> Could someone review this patch series. I haven't received any
> feedback till now.

I'm way behind, but fine with it going upstream via whatever tree is
appropriate. I think Arnd will take care of it.

Acked-by: Rich Felker <dalias@...c.org>

> FYI, this support is only available for 32-bit kernel, not 64-bit
> kernel. As I came across the 64-bit kernel is not active for long time.

Support for 64-bit, which AFAIK barely ever existed in hardware, was
removed from GCC a long time ago. At some point it needs to be removed
from the kernel too, and doing so should allow a lot of cleanup.

Rich