linux-kernel - Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 17:45:02 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Eddie James <eajames@...ux.vnet.ibm.com>,
        Eddie James <eajames@...ux.ibm.com>,
        linux-kernel@...r.kernel.org
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org, robh+dt@...nel.org,
        mchehab@...nel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

On 12/11/18 5:41 PM, Eddie James wrote:

<snip>

>> Running checkpatch.pl --strict over the patch gives me three 'CHECK' items
>> they you should also address:
>>
>> CHECK: struct mutex definition without comment
>> #312: FILE: drivers/media/platform/aspeed-video.c:222:
>> +       struct mutex video_lock;
>>
>> CHECK: spinlock_t definition without comment
>> #315: FILE: drivers/media/platform/aspeed-video.c:225:
>> +       spinlock_t lock;
>>
>> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
>> #580: FILE: drivers/media/platform/aspeed-video.c:490:
>> +       udelay(100);
> 
> This one has to be udelay due to possibly being called in the interrupt handler...

Please add a comment for that.

> 
>>
>> I think v8 can be the final version. It probably won't make 4.21, though.
>> If I'll get a v8 today, then there is a small chance it might still make it.
>> If not, then it'll be merged early in the 4.22 cycle.
> 
> OK, no worries either way. Will send v8 in a few.

Looking forward to that.

Regards,

	Hans

> 
> Thanks for all the review!
> Eddie
> 
>>
>> Regards,
>>
>>     Hans
>>
>