linux-kernel - Re: [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 01:05:13 +0800
From:   Gao Xiang <hsiangkao@....com>
To:     Joe Perches <joe@...ches.com>
Cc:     Gao Xiang <gaoxiang25@...wei.com>,
        Aaron Strahlberger <aaron.strahlberger@...teo.de>,
        devel@...verdev.osuosl.org,
        Julius Wiedmann <julius.wiedmann@....de>,
        linux-kernel@...cs.fau.de,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Dominik Huber <domi250@....de>,
        linux-erofs@...ts.ozlabs.org
Subject: Re: [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in
 macro

Hi Joe,

On 2018/12/11 23:48, Joe Perches wrote:
> This macro is used only once and is merely obfuscation
> for that one use.  Please remove the macro and expand
> it in the one place it is used.

I am also considering to replace it in a plain way,
it will be more straight-forward to describe its on-disk format.

Thanks for your suggestion.

Thanks,
Gao Xiang