linux-kernel - Re: [tip:x86/build] x86/um/vdso: Drop implicit common-page-size linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdmBNvpjiYDdP88c9TZHzqbf-GTcQqPdft+LgJXC+W26Dw@mail.gmail.com>
Date:   Tue, 11 Dec 2018 09:39:45 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     richard@....at, Masahiro Yamada <yamada.masahiro@...ionext.com>,
        mingo@...hat.com, LKML <linux-kernel@...r.kernel.org>,
        x86@...nel.org, hpa@...or.com, jdike@...toit.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, bp@...e.de
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/build] x86/um/vdso: Drop implicit common-page-size
 linker flag

On Tue, Dec 11, 2018 at 5:12 AM tip-bot for ndesaulniers@...gle.com
<tipbot@...or.com> wrote:
>
> Commit-ID:  f4313ba52f9caccfda6a55f991c84aba6726b88f
> Gitweb:     https://git.kernel.org/tip/f4313ba52f9caccfda6a55f991c84aba6726b88f
> Author:     ndesaulniers@...gle.com <ndesaulniers@...gle.com>
> AuthorDate: Mon, 10 Dec 2018 14:27:16 -0800
> Committer:  Borislav Petkov <bp@...e.de>
> CommitDate: Tue, 11 Dec 2018 13:58:57 +0100
>
> x86/um/vdso: Drop implicit common-page-size linker flag
>
> GNU linker's -z common-page-size's default value is based on the target
> architecture. arch/x86/um/vdso/Makefile sets it to the architecture
> default, which is implicit and redundant. Drop it so that one more LLVM
> build issue gets addressed.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Acked-by: Richard Weinberger <richard@....at>

I missed Richard's ACK.  Did it occur off list?  I just want to
confirm there's nothing wrong with my email client.  Thank you for
taking the patch either way.

> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-um@...ts.infradead.org
> Cc: x86-ml <x86@...nel.org>
> Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
> ---
>  arch/x86/um/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
> index 822ccdba93ad..bf94060fc06f 100644
> --- a/arch/x86/um/vdso/Makefile
> +++ b/arch/x86/um/vdso/Makefile
> @@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y)
>  CPPFLAGS_vdso.lds += -P -C
>
>  VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> -       -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
> +       -Wl,-z,max-page-size=4096
>
>  $(obj)/vdso.o: $(src)/vdso.S $(obj)/vdso.so
>


-- 
Thanks,
~Nick Desaulniers