linux-kernel - RE: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR07MB24692595C49430F56CE5DAC2C1A60@CO2PR07MB2469.namprd07.prod.outlook.com>
Date:   Tue, 11 Dec 2018 18:22:27 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "tj@...nel.org" <tj@...nel.org>, "jbacik@...com" <jbacik@...com>,
        "michaelcallahan@...com" <michaelcallahan@...com>,
        "snitzer@...hat.com" <snitzer@...hat.com>,
        "osandov@...com" <osandov@...com>,
        "keith.busch@...el.com" <keith.busch@...el.com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "shli@...com" <shli@...com>,
        "dennisszhou@...il.com" <dennisszhou@...il.com>,
        Alan Douglas <adouglas@...ence.com>,
        Janek Kotas <jank@...ence.com>,
        Rafal Ciepiela <rafalc@...ence.com>
Subject: RE: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS
 HCD

Hi Christoph,

Thank you for comments.
My comments are inline below.

Regards,
Parshuram Thombare

>-----Original Message-----
>From: Christoph Hellwig <hch@...radead.org>
>Sent: Tuesday, December 11, 2018 7:37 PM
>To: Parshuram Raju Thombare <pthombar@...ence.com>
>Cc: axboe@...nel.dk; vinholikatti@...il.com; jejb@...ux.vnet.ibm.com;
>martin.petersen@...cle.com; mchehab+samsung@...nel.org;
>gregkh@...uxfoundation.org; davem@...emloft.net; akpm@...ux-
>foundation.org; nicolas.ferre@...rochip.com; arnd@...db.de; linux-
>kernel@...r.kernel.org; linux-block@...r.kernel.org; linux-
>scsi@...r.kernel.org; tj@...nel.org; jbacik@...com; michaelcallahan@...com;
>snitzer@...hat.com; osandov@...com; keith.busch@...el.com;
>ming.lei@...hat.com; shli@...com; dennisszhou@...il.com; Alan Douglas
><adouglas@...ence.com>; Janek Kotas <jank@...ence.com>; Rafal Ciepiela
><rafalc@...ence.com>
>Subject: Re: [PATCH 0/2] scsi: ufs: add real time/inline crypto support to UFS HCD
>
>EXTERNAL MAIL
>
>
>Patch 1 is missing in your series.
>
>But even without looking at it I think your design doesn't make a whole lot of
>sense.  If the encryption is implemented in the ufs driver you should not need
>device mapper support for it, just ufs driver support and maybe a little block layer
>glue.
[PATCH 1/2]  does nothing more than adding variable in 'struct bio'. 
Here is link of it.
https://lkml.org/lkml/2018/12/11/193
One reason of using device mapper here is to use existing tools like 'dmsetup', otherwise 
some user space application is needed and may be some changes in block layer to 
pass the crypto information (crypto algorithm, key etc) till ufs driver.
Another reason is supporting multiple UFS devices. I think, as you said UFS crypto support
can be added by some change in ufs driver and block layer glue. But to support
multiple UFS crypto devices having different crypto configs (crypto algorithms, key size etc),
crypto context need to be saved per crypto device which may need some changes in block layer code.