linux-kernel - Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181211185947.gnaachztyh3ils7o@pburton-laptop>
Date:   Tue, 11 Dec 2018 18:59:49 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Firoz Khan <firoz.khan@...aro.org>
CC:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

Hi Firoz,

On Tue, Dec 11, 2018 at 02:15:19PM +0530, Firoz Khan wrote:
> > > diff --git a/arch/mips/include/uapi/asm/sgidefs.h b/arch/mips/include/uapi/asm/sgidefs.h
> > > index 26143e3..0364eec 100644
> > > --- a/arch/mips/include/uapi/asm/sgidefs.h
> > > +++ b/arch/mips/include/uapi/asm/sgidefs.h
> > > @@ -40,6 +40,6 @@
> > >   */
> > >  #define _MIPS_SIM_ABI32              1
> > >  #define _MIPS_SIM_NABI32     2
> > > -#define _MIPS_SIM_ABI64              3
> > > +#define _MIPS_SIM_ABIN64     3
> >
> > Whilst I agree with changing our own definitions & filenames to use n64,
> > this macro actually reflects naming used by the toolchain. ie:
> >
> >     $ mips-linux-gcc -mips64 -mabi=64 -dM -E - </dev/null | grep ABI64
> >     #define _ABI64 3
> >     #define _MIPS_SIM _ABI64
> >
> > Our macro here is used to compare against _MIPS_SIM provided by the
> > toolchain, so for consistency I think we should keep the same name for
> > the macro that the toolchain uses.
> 
> Will this below change will help?
> 
>  #define _MIPS_SIM_ABI32              1
>  #define _MIPS_SIM_NABI32            2
>  #define _MIPS_SIM_ABI64              3
> +#define _MIPS_SIM_ABIN64           _MIPS_SIM_ABI64

Hmm, I think I'd prefer that we just keep using _MIPS_SIM_ABI64.

Side note - this snippet of code shows another inconsistency... we have
_MIPS_SIM_NABI32 whilst the toolchain uses _ABIN32... No need to worry
about that here though. In short let's leave _MIPS_SIM_* alone in this
series.

Thanks,
    Paul