linux-kernel - Re: [PATCH v3 3/4] i2c: Add Actions Semiconductor Owl family S700 I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181211205444.rpfn5cmsndy4y2lv@ninjato>
Date:   Tue, 11 Dec 2018 21:54:44 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Parthiban Nallathambi <pn@...x.de>
Cc:     manivannan.sadhasivam@...aro.org, afaerber@...e.de,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux@...ietech.com, thomas.liau@...ions-semi.com,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH v3 3/4] i2c: Add Actions Semiconductor Owl family S700
 I2C support

On Tue, Dec 11, 2018 at 09:04:47AM +0100, Parthiban Nallathambi wrote:
> Add S700 to the list of devices supported by Owl I2C driver.
> 
> Add Actions Semiconductor Owl family S700 I2C driver.
> 
> Signed-off-by: Parthiban Nallathambi <pn@...x.de>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Rob, is this okay or should we drop this patch and update the DT to
contain first the s700 compatible and then s900 as fallback?

> ---
>  drivers/i2c/busses/i2c-owl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 96b4572e6d9c..b6b5a495118b 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -475,6 +475,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id owl_i2c_of_match[] = {
> +	{ .compatible = "actions,s700-i2c" },
>  	{ .compatible = "actions,s900-i2c" },
>  	{ /* sentinel */ }
>  };
> -- 
> 2.17.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)