linux-kernel - Re: [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <620b7955-de9c-a273-bf1c-5521834e16a6@kernel.org>
Date:   Tue, 11 Dec 2018 17:00:22 -0500
From:   Sinan Kaya <okaya@...nel.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] ACPI: Allow PCI to be disabled for reboot

On 12/11/2018 4:49 PM, Rafael J. Wysocki wrote:
>> I struggled between break and return. Existing code seems to return on failure
>> when bus0 is NULL. I assumed it would be more logical to return as someone could
>> put some code after here that assumes everything is in order.
> Well, there's no such code ATM, so there's no practical difference
> between the two and you don't really need the #else branch at all, do
> you?
> 

OK. I'll go with break.