linux-kernel - Re: [PATCH 1/7] [DSA] adding fields for holding information about upstream-port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 14:37:42 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Frank Wunderlich <frank-w@...lic-files.de>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        "David S. Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/7] [DSA] adding fields for holding information about
 upstream-port

Hi,,

On 12/11/18 11:33 AM, Frank Wunderlich wrote:
> based on
> https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch

There are several stylistic as well as logistical/technical issues with
this patch series, so please address those before we can start doing the
technical review:

- this is a multi patch series, so a cover letter should be provided
(can be done with git format-patch --cover-letter)

- subject for the patches should be prefixed with net: dsa: <subject>

- commit messages explaining what is being achieved, how and what
problem/feature this is providing is mandatory, you cannot just take
patches from OpenWrt and provide no context what so ever except from the
subject

Please fix that so we can do a meaningful and constructive technical
review of the patches.

Thank you

> 
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> ---
>  include/net/dsa.h  | 4 ++++
>  net/dsa/dsa_priv.h | 5 +++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 23690c44e167..3efa81e08993 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -203,6 +203,10 @@ struct dsa_port {
>  	struct net_device	*bridge_dev;
>  	struct devlink_port	devlink_port;
>  	struct phylink		*pl;
> +
> +	struct net_device	*ethernet;
> +	int			upstream;
> +
>  	/*
>  	 * Original copy of the master netdev ethtool_ops
>  	 */
> diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
> index 9e4fd04ab53c..cc0cd7675117 100644
> --- a/net/dsa/dsa_priv.h
> +++ b/net/dsa/dsa_priv.h
> @@ -81,6 +81,8 @@ struct dsa_slave_priv {
>  
>  	/* TC context */
>  	struct list_head	mall_tc_list;
> +
> +	struct net_device       *master;
>  };
>  
>  /* dsa.c */
> @@ -188,7 +190,10 @@ static inline struct net_device *
>  dsa_slave_to_master(const struct net_device *dev)
>  {
>  	struct dsa_port *dp = dsa_slave_to_port(dev);
> +	struct dsa_slave_priv *p = netdev_priv(dev);
>  
> +	if (p->master)
> +		return p->master;
>  	return dp->cpu_dp->master;
>  }
>  
> 


-- 
Florian