linux-kernel - Re: [PATCH v5 22/25] syscall_get_arch: add "struct task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60665b1e6b520854f1f3d3bd658d884d85e56178.camel@redhat.com>
Date:   Tue, 11 Dec 2018 17:44:59 -0500
From:   Mark Salter <msalter@...hat.com>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-c6x-dev <linux-c6x-dev@...ux-c6x.org>
Subject: Re: [PATCH v5 22/25] syscall_get_arch: add "struct task_struct *"
 argument

On Mon, 2018-12-10 at 07:31 +0300, Dmitry V. Levin wrote:
> This argument is required to extend the generic ptrace API with
> PTRACE_GET_SYSCALL_INFO request: syscall_get_arch() is going
> to be called from ptrace_request() along with syscall_get_nr(),
> syscall_get_arguments(), syscall_get_error(), and
> syscall_get_return_value() functions with a tracee as their argument.
> 
> Reverts: 5e937a9ae913 ("syscall_get_arch: remove useless function arguments")
> Reverts: 1002d94d3076 ("syscall.h: fix doc text for syscall_get_arch()")
> Reviewed-by: Andy Lutomirski <luto@...nel.org> # for x86
> Reviewed-by: Palmer Dabbelt <palmer@...ive.com>
> Acked-by: Paul Burton <paul.burton@...s.com> # MIPS parts
> Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
> Cc: Eric Paris <eparis@...hat.com>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Richard Henderson <rth@...ddle.net>
> Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
> Cc: Matt Turner <mattst88@...il.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Mark Salter <msalter@...hat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@...il.com>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Richard Kuo <rkuo@...eaurora.org>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Greentime Hu <green.hu@...il.com>
> Cc: Vincent Chen <deanbo422@...il.com>
> Cc: Ley Foon Tan <lftan@...era.com>
> Cc: Jonas Bonn <jonas@...thpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
> Cc: Stafford Horne <shorne@...il.com>
> Cc: James E.J. Bottomley <jejb@...isc-linux.org>
> Cc: Helge Deller <deller@....de>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: Rich Felker <dalias@...c.org>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Guan Xuetao <gxt@....edu.cn>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Will Drewry <wad@...omium.org>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Elvira Khabirova <lineprinter@...linux.org>
> Cc: Eugene Syromyatnikov <esyr@...hat.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: James Hogan <jhogan@...nel.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: linux-alpha@...r.kernel.org
> Cc: linux-snps-arc@...ts.infradead.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-c6x-dev@...ux-c6x.org
> Cc: uclinux-h8-devel@...ts.sourceforge.jp
> Cc: linux-hexagon@...r.kernel.org
> Cc: linux-ia64@...r.kernel.org
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: linux-mips@...r.kernel.org
> Cc: nios2-dev@...ts.rocketboards.org
> Cc: openrisc@...ts.librecores.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: linux-riscv@...ts.infradead.org
> Cc: linux-s390@...r.kernel.org
> Cc: linux-sh@...r.kernel.org
> Cc: sparclinux@...r.kernel.org
> Cc: linux-um@...ts.infradead.org
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: linux-arch@...r.kernel.org
> Cc: linux-audit@...hat.com
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> ---
> 
> Notes:
>     v5: fixed asm-generic docs by reverting 1002d94d3076, added Cc
>     v2: cleaned up mips part, added Reviewed-by
> 
>  arch/alpha/include/asm/syscall.h      |  2 +-
>  arch/arc/include/asm/syscall.h        |  2 +-
>  arch/arm/include/asm/syscall.h        |  2 +-
>  arch/arm64/include/asm/syscall.h      |  4 ++--
>  arch/c6x/include/asm/syscall.h        |  2 +-

For the c6x bit,
Acked-by: Mark Salter <msalter@...hat.com>