linux-kernel - Re: [PATCH v5 3/7] mtd: spi-nor: add opcodes for octal Read/Write commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <141c6d79-ae7a-60aa-865a-f6b6997f8da9@microchip.com>
Date:   Tue, 11 Dec 2018 08:09:40 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <yogeshnarayan.gaur@....com>, <linux-mtd@...ts.infradead.org>,
        <boris.brezillon@...tlin.com>, <broonie@...nel.org>,
        <marek.vasut@...il.com>, <vigneshr@...com>,
        <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>
CC:     <robh@...nel.org>, <mark.rutland@....com>, <shawnguo@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <computersforpeace@...il.com>, <frieder.schrempf@...eet.de>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 3/7] mtd: spi-nor: add opcodes for octal Read/Write
 commands

Hi,

On 12/11/2018 06:55 AM, Yogesh Narayan Gaur wrote:
> Thus would going to modify the condition check as below, so that SFDP parsing would also be performed when SPI_NOR_OCTAL_READ is set. Correct?
> 
>         if ((info->flags & (SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>              SPI_NOR_OCTAL_READ)) && !(info->flags & SPI_NOR_SKIP_SFDP)) {

Yes, this is what I was suggesting. On a second thought, we haven't added yet
support for parsing sfdp to get the octal mode info, so the parsing will be done
gratuitously. Let's drop this change and add it when adding support for parsing
octal mode info from sfdp. I'll prepare a patch for this.

Please rebase on top of spi-nor/next, s/octo/octal in spi-nor.h and correct your
S-o-b tag and you'll have my R-b tag.

Thanks Yogesh,
ta