[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <01021c8571af27995acbaaca7a1a68f0@suse.de>
Date: Tue, 11 Dec 2018 09:57:11 +0100
From: osalvador@...e.de
To: akpm@...ux-foundation.org
Cc: mhocko@...e.com, david@...hat.com, pasha.tatashin@...een.com,
dan.j.williams@...il.com, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, owner-linux-mm@...ck.org
Subject: Re: [PATCH] mm, memory_hotplug: Don't bail out in do_migrate_range
prematurely
On 2018-12-11 09:50, Oscar Salvador wrote:
> - } else {
> - pr_warn("failed to isolate pfn %lx\n", pfn);
> - dump_page(page, "isolation failed");
> - put_page(page);
> - /* Because we don't have big zone->lock. we should
> - check this again here. */
> - if (page_count(page)) {
> - not_managed++;
> - ret = -EBUSY;
> - break;
I forgot that here we should at least leave the put_page().
But leave also the dump_page() and the pr_warn().
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1394,6 +1394,10 @@ do_migrate_range(unsigned long start_pfn,
unsigned long end_pfn)
inc_node_page_state(page,
NR_ISOLATED_ANON +
page_is_file_cache(page));
+ } else {
+ pr_warn("failed to isolate pfn %lx\n", pfn);
+ dump_page(page, "isolation failed");
+ put_page(page);
}
}
if (!list_empty(&source)) {
Powered by blists - more mailing lists