linux-kernel - Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181211001050.GA1578@tuxbook-pro>
Date:   Mon, 10 Dec 2018 16:10:50 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Mark Rutland <mark.rutland@....com>, robh+dt@...nel.org,
        gregkh@...uxfoundation.org, arnd@...db.de,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, bkumar@....qualcomm.com,
        thierry.escande@...aro.org
Subject: Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings

On Mon 10 Dec 03:17 PST 2018, Srinivas Kandagatla wrote:
> On 07/12/18 18:23, Mark Rutland wrote:
> > On Fri, Dec 07, 2018 at 04:35:08PM +0000, Srinivas Kandagatla wrote:
> > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
[..]
> > > +- reg
> > > +	Usage: required
> > > +	Value type: <u32>
> > > +	Definition: DSP Processor ID.
> > > +	Possible values are :
> > > +			0 - ADSP
> > > +			1 - MDSP
> > > +			2 - SDSP
> > > +			3 - CDSP
> > 
> > Why is this in a reg?
> 
> This is to identify which type of dsp(Audio/Modem/Sensor/Compute) it is,
> This information is used to create device nodes for user-space access.
> 

But it does not represent FastRPC's address on the rpmsg bus. How about
replacing it with a "label" (or "qcom,domain" perhaps?) of type string?

Regards,
Bjorn