linux-kernel - Re: [PATCH] drivers: staging: erofs: Fix styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ed9f3e7-9081-4a8a-06b0-e5ad14e2c872@huawei.com>
Date:   Tue, 11 Dec 2018 17:18:27 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Aaron Strahlberger <aaron.strahlberger@...teo.de>
CC:     Chao Yu <yuchao0@...wei.com>, <linux-erofs@...ts.ozlabs.org>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <linux-kernel@...cs.fau.de>,
        Julius Wiedmann <julius.wiedmann@....de>,
        Dominik Huber <domi250@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] drivers: staging: erofs: Fix styling issues

Hi Aaron,

On 2018/12/11 17:06, Aaron Strahlberger wrote:
> Fixed following checkpatch.pl styling issues:
> 
> - 17x CHECK: Alignment should match open parenthesis
> -  7x CHECK: Comparison to NULL could be written ...
> -  1x CHECK: Lines should not end with a '('
> -  1x CHECK: Please use a blank line after ...
> 
> Signed-off-by: Aaron Strahlberger <aaron.strahlberger@...teo.de>
> Signed-off-by: Julius Wiedmann <julius.wiedmann@....de>
> Signed-off-by: Dominik Huber <domi250@....de>

Thanks for taking time to work on this submitted patch. :)

As a matter of practice, it is perfered to keep each patch
fixes one kind of these issues you found...separate into 4 patches could be better...

In addition, you need send to Greg Kroah-Hartman <gregkh@...uxfoundation.org>
for upstream...

Thanks,
Gao Xiang