linux-kernel - Re: [PATCH] ASoC: simple-card-utils: fix build warning without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k1kgc415.wl-kuninori.morimoto.gx@renesas.com>
Date:   Tue, 11 Dec 2018 00:25:14 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: fix build warning without
 CONFIG_OF


Hi

> When CONFIG_OF is disabled, of_graph_parse_endpoint() does not
> initialize 'info', and gcc can see that:
> 
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_card_parse_graph_dai':
> sound/soc/generic/simple-card-utils.c:284:13: error: 'info.port' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> It's probably best to check the return code anyway, and that also
> takes care of the warning.
> 
> Fixes: b6f3fc005a2c ("ASoC: simple-card-utils: fixup asoc_simple_card_get_dai_id() counting")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>