linux-kernel - Re: [PATCH v2] cpufreq: pmac64: add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1962056.WEnsRsenr7@aspire.rjw.lan>
Date:   Tue, 11 Dec 2018 11:47:45 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Yangtao Li <tiny.windzz@...il.com>
Cc:     benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        linux-pm@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: pmac64: add of_node_put()

On Monday, November 26, 2018 7:02:26 AM CET Viresh Kumar wrote:
> On 23-11-18, 08:33, Yangtao Li wrote:
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > g5_neo2_cpufreq_init() doesn't do that, so fix it.
> > 
> > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> > ---
> > Changes in v2:
> > -update changelog
> > ---
> >  drivers/cpufreq/pmac64-cpufreq.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
> > index be623dd7b9f2..1d32a863332d 100644
> > --- a/drivers/cpufreq/pmac64-cpufreq.c
> > +++ b/drivers/cpufreq/pmac64-cpufreq.c
> > @@ -411,6 +411,7 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode)
> >  		pfunc_set_vdnap0 = pmf_find_function(root, "set-vdnap0");
> >  		pfunc_vdnap0_complete =
> >  			pmf_find_function(root, "slewing-done");
> > +		of_node_put(root);
> >  		if (pfunc_set_vdnap0 == NULL ||
> >  		    pfunc_vdnap0_complete == NULL) {
> >  			pr_err("Can't find required platform function\n");
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Patch applied, thanks!