linux-kernel - Re: [PATCH v6 20/20] PM: Switch to use %ptR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vc_vQE60UQQWGHJ8BvZSCK-VoU6n76pE-=SDKpkz2MU5w@mail.gmail.com>
Date:   Tue, 11 Dec 2018 14:29:20 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        Joe Perches <joe@...ches.com>,
        Mark Salyzyn <salyzyn@...roid.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v6 20/20] PM: Switch to use %ptR

On Tue, Dec 11, 2018 at 2:12 PM Rafael J. Wysocki <rjw@...ysocki.net> wrote:
>
> On Tuesday, December 4, 2018 10:23:30 PM CET Andy Shevchenko wrote:
> > Use %ptR instead of open coded variant to print content of
> > struct rtc_time in human readable format.
> >
> > Cc: linux-pm@...r.kernel.org
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Do you want me to take this patch?

Alexandre took all of them, thanks!

>
> > ---
> >  drivers/base/power/trace.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
> > index 1cda505d6a85..b11f47a1e819 100644
> > --- a/drivers/base/power/trace.c
> > +++ b/drivers/base/power/trace.c
> > @@ -118,9 +118,7 @@ static unsigned int read_magic_time(void)
> >       unsigned int val;
> >
> >       mc146818_get_time(&time);
> > -     pr_info("RTC time: %2d:%02d:%02d, date: %02d/%02d/%02d\n",
> > -             time.tm_hour, time.tm_min, time.tm_sec,
> > -             time.tm_mon + 1, time.tm_mday, time.tm_year % 100);
> > +     pr_info("RTC time: %ptRt, date: %ptRd\n", &time, &time);
> >       val = time.tm_year;                             /* 100 years */
> >       if (val > 100)
> >               val -= 100;
> >
>
>


-- 
With Best Regards,
Andy Shevchenko