linux-kernel - Re: [PATCH] staging: vchiq: rework remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 13:30:55 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Arnd Bergmann <arnd@...db.de>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tara Null <tn@...tmail.net>, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] staging: vchiq: rework remove_event handling

On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote:
> On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> > Note that I'm changing it back to 'killable' after the previous
> > patch
> > changed 'killable' to 'interruptible', apparently based on a
> > misunderstanding
> > of the subtle down_interruptible() macro override in
> > vchiq_killable.h.
> 
> Oh wow...  The non standard down_interruptible() macro is ugly.
> 

Same reaction here, *_*. I wasn't even aware of it.

Arnd, as long as it you're not doing it already. I'll prepare some
extra fixes for the rest of completions and get rid of that file
altogether.

Regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)