linux-kernel - Re: [PATCH 1/2] block: add bi_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62281c61-de73-a0a3-2ea2-eeea81778eea@kernel.dk>
Date:   Tue, 11 Dec 2018 06:37:04 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Parshuram Thombare <pthombar@...ence.com>, tj@...nel.org,
        jbacik@...com, michaelcallahan@...com, snitzer@...hat.com,
        osandov@...com, keith.busch@...el.com, ming.lei@...hat.com,
        shli@...com, dennisszhou@...il.com, linux-kernel@...r.kernel.org
Cc:     adouglas@...ence.com, jank@...ence.com, rafalc@...ence.com
Subject: Re: [PATCH 1/2] block: add bi_crypto_ctx variable in struct bio

On 12/11/18 2:50 AM, Parshuram Thombare wrote:
> Add variable 'void *bi_crypt_ctx' in 'struct bio'. This will
> be used to associate bio with crypto configuration of controller
> supporting real time / inline encryption/decryption.
> 
> Signed-off-by: Parshuram Thombare <pthombar@...ence.com>
> ---
>  include/linux/blk_types.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 1dcf652..bd77603 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -188,6 +188,10 @@ struct bio {
>  #endif
>  	};
>  
> +#ifdef CONFIG_BLK_DEV_HW_RT_ENCRYPTION
> +	void *bi_crypto_ctx;
> +#endif
> +
>  	unsigned short		bi_vcnt;	/* how many bio_vec's */
>  
>  	/*

Pretty sure I mentioned this last time, but in case I didn't, don't
add bio members for random drivers. Can you imagine how huge
this thing would be if we allowed that?

If you need per-io storage, put it in the payload for the blk-mq
request. That way you are only bloating your own IO related data
structures, not everyones.

-- 
Jens Axboe