linux-kernel - Re: [PATCH] staging: vchiq: rework remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 15:18:42 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     nsaenzjulienne@...e.de
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        driverdevel <devel@...verdev.osuosl.org>,
        gregkh <gregkh@...uxfoundation.org>, tn@...tmail.net,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] staging: vchiq: rework remove_event handling

On Tue, Dec 11, 2018 at 1:31 PM Nicolas Saenz Julienne
<nsaenzjulienne@...e.de> wrote:
>
> On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote:
> > On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> > > Note that I'm changing it back to 'killable' after the previous
> > > patch
> > > changed 'killable' to 'interruptible', apparently based on a
> > > misunderstanding
> > > of the subtle down_interruptible() macro override in
> > > vchiq_killable.h.
> >
> > Oh wow...  The non standard down_interruptible() macro is ugly.
> >
>
> Same reaction here, *_*. I wasn't even aware of it.
>
> Arnd, as long as it you're not doing it already. I'll prepare some
> extra fixes for the rest of completions and get rid of that file
> altogether.

Ok, please do that, and add me to Cc. I think there is one
counting semaphore left (g_free_fragments_sema), which could
just use the plain down_killable() before you remove the wrapper.

I actually have another (longer) patch series that is not entirely
ready to convert all counting semaphores into a new
'struct counting_semaphore' to split them away from the
semaphores that can be converted into mutexes, completions
or other replacements.

       Arnd