linux-kernel - Re: [RESEND PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181212061404.GK4497@dell>
Date:   Wed, 12 Dec 2018 06:14:04 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel@...r.kernel.org, robert.jarzmik@...e.fr,
        daniel.thompson@...aro.org, kernel@...labora.com, heiko@...ech.de,
        stable@...r.kernel.org, u.kleine-koenig@...gutronix.de,
        linux-pwm@...r.kernel.org, linux-fbdev@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org, Jingoo Han <jingoohan1@...il.com>
Subject: Re: [RESEND PATCH v3] backlight: pwm_bl: Fix brightness levels for
 non-DT case.

On Mon, 10 Dec 2018, Enric Balletbo i Serra wrote:

> Commit '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED
> linearly to human eye")' allows the possibility to compute a default
> brightness table when there isn't the brightness-levels property in the
> DT. Unfortunately the changes made broke the pwm backlight for the
> non-DT boards.
> 
> Usually, the non-DT boards don't pass the brightness levels via platform
> data, instead, it sets the max_brightness in their platform data and the
> driver calculates the level without a table. The offending patch assumed
> that when there is no brightness levels table we should create one, but this
> is clearly wrong for the non-DT case.
> 
> After this patch the code handles the DT and the non-DT case taking in
> consideration also if max_brightness is set or not.
> 
> Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye")
> Cc: <stable@...r.kernel.org>
> Reported-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> ---
> 
> Changes in v3:
> - Fixed some typos in commit message.
> - Removed ' in Fixes tag.
> 
> Changes in v2:
> - Rebase on top of mainline
> - Add Tested-by and Acked-by tags.
> 
>  drivers/video/backlight/pwm_bl.c | 41 +++++++++++++++++++++++++++-----
>  1 file changed, 35 insertions(+), 6 deletions(-)

FYI, this patch is now in Mainline.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog