linux-kernel - Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 22:46:52 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Ashish Mhetre <amhetre@...dia.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, axboe@...nel.dk, adrian.hunter@...el.com,
        ulf.hansson@...aro.org, linux-crypto@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        vdumpa@...dia.com, mmaddireddy@...dia.com
Cc:     linux-tegra@...r.kernel.org, Snikam@...dia.com
Subject: Re: [PATCH] scatterlist: Update size type to support greater then 4GB
 size.


>   struct nvme_sgl_desc {
>   	__le64	addr;
> -	__le32	length;
> +	__le64	length;
>   	__u8	rsvd[3];
>   	__u8	type;
>   };

in what world changing a wire protocol for this make sense?

please get rid of this hunk, NVMe will never cross the 32 bit sg element 
size.