lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Dec 2018 08:55:51 +0200
From: Felipe Balbi <balbi@...nel.org>
To: Peter Chen <hzpeterchen@...il.com>, pawell@...ence.com
Cc: devicetree@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, rogerq@...com,
lkml <linux-kernel@...r.kernel.org>, adouglas@...ence.com,
jbergsagel@...com, nsekhar@...com, nm@...com, sureshp@...ence.com,
peter.chen@....com, pjez@...ence.com, kurahul@...ence.com
Subject: Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Peter Chen <hzpeterchen@...il.com> writes:
>> >> + tmode = le16_to_cpu(ctrl->wIndex);
>> >> +
>> >> + if (!set || (tmode & 0xff) != 0)
>> >> + return -EINVAL;
>> >> +
>> >> + switch (tmode >> 8) {
>> >> + case TEST_J:
>> >> + case TEST_K:
>> >> + case TEST_SE0_NAK:
>> >> + case TEST_PACKET:
>> >> + cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
>> >> + USB_CMD_STMODE |
>> >> + USB_STS_TMODE_SEL(tmode - 1));
>> >
>> >I'm 90% sure this won't work. There's a reason why we only enter the
>> >requested test mode from status stage. How have you tested this?
>>
>
> What's the reason?
> It can work although the code is a little different with above, I
> tested it using USBxHSETT tool at Windows.
put a sniffer. Status stage won't complete
>> >> + irqreturn_t ret = IRQ_NONE;
>> >> + unsigned long flags;
>> >> + u32 reg;
>> >> +
>> >> + priv_dev = cdns->gadget_dev;
>> >> + spin_lock_irqsave(&priv_dev->lock, flags);
>> >
>> >you're already running in hardirq context. Why do you need this lock at
>> >all? I would be better to use the hardirq handler to mask your
>> >interrupts, so they don't fire again, then used the top-half (softirq)
>> >handler to actually handle the interrupts.
>>
>
> This controller may be ran at SMP environment, register and flag access
> needs to be protected among CPUs running.
in hardirq context? When interrupts are already disabled?
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)
Powered by blists - more mailing lists