[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2018 13:15:15 +0530
From: Ashish Mhetre <amhetre@...dia.com>
To: Sagi Grimberg <sagi@...mberg.me>,
David Miller <davem@...emloft.net>
CC: <axboe@...nel.dk>, <ulf.hansson@...aro.org>,
<herbert@...dor.apana.org.au>, <mmaddireddy@...dia.com>,
<Snikam@...dia.com>, <adrian.hunter@...el.com>,
<linux-nvme@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<vdumpa@...dia.com>, <linux-crypto@...r.kernel.org>,
<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] scatterlist: Update size type to support greater then 4GB
size.
On 12/12/18 12:19 PM, Sagi Grimberg wrote:
>
>>> struct nvme_sgl_desc {
>>> __le64 addr;
>>> - __le32 length;
>>> + __le64 length;
>>> __u8 rsvd[3];
>>> __u8 type;
>>> };
>>
>> Isn't this a device or protocol defined datastructure? You can't just
>> change it like this.
>
> You're correct, we can't...
> [Replied before seeing this issue was already highlighted]
>
> The positive side is that it can safely be removed without affecting the
> rest of the patch...
Ohh, I am not aware of this protocol defined data-structures. But it
seems that this need not be changed as Sagi is saying sg length for NVME
will never cross 32 bit size.
I'll send a new version removing this change. Thanks.
Powered by blists - more mailing lists