[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2018 11:23:16 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Jeremy Fertic <jeremyfertic@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, devel@...verdev.osuosl.org,
Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
linux-iio@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Hartmut Knaack <knaack.h@....de>
Subject: Re: [PATCH 04/11] staging: iio: adt7316: fix handling of dac high
resolution option
On Tue, Dec 11, 2018 at 05:54:56PM -0700, Jeremy Fertic wrote:
> @@ -651,10 +649,12 @@ static ssize_t adt7316_store_da_high_resolution(struct device *dev,
> u8 config3;
> int ret;
>
> + if (chip->id == ID_ADT7318 || chip->id == ID_ADT7519)
> + return -EPERM;
return -EINVAL is more appropriate than -EPERM.
regards,
dan carpenter
Powered by blists - more mailing lists