linux-kernel - Re: [PATCH] ARM: shmobile: fix build regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 11:30:33 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Magnus Damm <magnus.damm@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Biju Das <biju.das@...renesas.com>,
        Fabrizio Castro <fabrizio.castro@...renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: fix build regressions

On Tue, Dec 11, 2018 at 09:58:05AM +0100, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Mon, Dec 10, 2018 at 10:00 PM Arnd Bergmann <arnd@...db.de> wrote:
> > A number of Kconfig options have become available now to random ARM
> > platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig
> > warnings, and other build errors when those select options that
> > lack additonal dependencies, e.g.:
> >
> > WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
> >   Depends on [n]: CPU_V7 [=n]
> >   Selected by [y]:
> >   - ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
> >   - ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]
> >
> > WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
> >   Depends on [n]: GENERIC_CLOCKEVENTS [=n]
> >   Selected by [y]:
> >   - ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]
> >
> > Put the old dependency on ARCH_RENESAS back for the moment to restore
> > the previous behavior.
> >
> > Fixes: 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/soc/renesas/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> > index 4d8012e1205c..68bfca6f20dd 100644
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -44,7 +44,7 @@ config ARCH_RZN1
> >         bool
> >         select ARM_AMBA
> >
> > -if ARM
> > +if ARM && ARCH_RENESAS
> 
> After a closer look, I think restricting this from ARM to ARCH_MULTI_V7
> should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM
> selects GENERIC_CLOCKEVENTS).

Hi Arnd,

what is your preferred way forwards here?
I'm tempted to take your patch as-is and then work on
refining the dependency as a follow-up.