lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 12 Dec 2018 11:36:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yangtao Li <tiny.windzz@...il.com>
Cc:     pure.logic@...us-software.ie, johan@...nel.org, elder@...nel.org,
        david.kershner@...sys.com, eric@...olt.net, stefan.wahren@...e.com,
        viro@...iv.linux.org.uk, kernelpatch@....com,
        natechancellor@...il.com, keescook@...omium.org,
        colin.king@...onical.com, devel@...verdev.osuosl.org,
        sparmaintainer@...sys.com, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] staging: convert to DEFINE_SHOW_ATTRIBUTE

On Sun, Dec 09, 2018 at 11:27:42AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/staging/fwserial/fwserial.c           | 32 +++----------------
>  drivers/staging/greybus/loopback.c            | 16 ++--------
>  drivers/staging/rtlwifi/debug.c               | 23 ++++---------
>  .../staging/unisys/visorhba/visorhba_main.c   | 14 +-------
>  .../interface/vchiq_arm/vchiq_debugfs.c       | 14 +-------
>  5 files changed, 14 insertions(+), 85 deletions(-)


Please break this up into one-patch-per-driver, so that the correct
people can properly review it, and you don't send patches out to people
who have no interested in other drivers.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ