linux-kernel - Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 15:06:07 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     mjg59@...f.ucam.org, dvhart@...radead.org, andy@...radead.org,
        mario.limonciello@...l.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight
 change event

On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
> There's a new wmi event generated by dell-wmi when pressing keyboard
> backlight hotkey:
> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
> 
> This event is for notification purpose, let's ignore it. The keyboard
> backlight hotkey uses another event so it still works without event
> 0x3f.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
>  drivers/platform/x86/dell-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 16c7f3d9a335..c3166ba73e9a 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	/* Fn-lock switched to multimedia keys */
>  	{ KE_IGNORE, 0x1, { KEY_RESERVED } },
>  
> +	/* Keyboard backlight change notification */
> +	{ KE_IGNORE, 0x3f, { KEY_RESERVED } },
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
>  

Looks good.

Reviewed-by: Pali Rohár <pali.rohar@...il.com>

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)