linux-kernel - Re: [PATCH] tpm-dev: Require response to be read only if there actually is a response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 19:53:17 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Alexander Steffen <Alexander.Steffen@...ineon.com>
Cc:     Tadeusz Struk <tadeusz.struk@...el.com>, jgg@...pe.ca,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm-dev: Require response to be read only if there
 actually is a response

On Thu, Dec 06, 2018 at 06:58:01PM +0100, Alexander Steffen wrote:
> If the tpm_transmit call in tpm_common_write fails for any reason, there is
> no response that could be read. Therefore, do not require the application
> to issue a read call before sending further commands. This restores the
> behavior from before support for partial reads was introduced.
> 
> Signed-off-by: Alexander Steffen <Alexander.Steffen@...ineon.com>
> ---
> Feel free to merge this into Tadeusz' original commit.

Thank you, good catch.

My PR is a bit late becuse just came from Oregon back to Finland so
I'll follow your advice and squash this. Thanks again.

/Jarkko