linux-kernel - Re: [PATCH 4/7] selftest/bpf: test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 10:41:01 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Alice Ferrazzi <alice.ferrazzi@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, shuah@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix

On Tue, 11 Dec 2018 20:56:04 +0900, Alice Ferrazzi wrote:
> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@...il.com>

Thanks, are you just running pylint to catch those?  I tried in the
past but it's very noisy and it lacked "understanding" of some python3
modules.  Would you mind giving us a quick 101 of how to catch such
errors? :)

> -def bpf_obj(name, sec=".text", path=bpf_test_dir,):
> +
> +def bpf_obj(name, sec=".text", path=bpf_test_dir, ):
>      return "obj %s sec %s" % (os.path.join(path, name), sec)
>  

I think this one is just a typo.  bpf_obj() seems to always get called
with one param, no?