linux-kernel - Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 16:31:01 -0500
From:   Sinan Kaya <okaya@...nel.org>
To:     "Schmauss, Erik" <erik.schmauss@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when
 CONFIG_PCI is unset

On 12/12/2018 4:16 PM, Schmauss, Erik wrote:
> 
> 
>> -----Original Message-----
>> From: Rafael J. Wysocki [mailto:rafael@...nel.org]
>> Sent: Wednesday, December 12, 2018 1:07 PM
>> To: okaya@...nel.org; Schmauss, Erik <erik.schmauss@...el.com>
>> Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>; Moore, Robert
>> <robert.moore@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>;
>> Len Brown <lenb@...nel.org>; devel@...ica.org; Linux Kernel Mailing List
>> <linux-kernel@...r.kernel.org>
>> Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when
>> CONFIG_PCI is unset
>>
>> On Wed, Dec 12, 2018 at 8:34 PM Sinan Kaya <okaya@...nel.org> wrote:
>>>
>>> On 12/12/2018 2:02 PM, Schmauss, Erik wrote:
>>>>> ++ b/drivers/acpi/acpica/achware.h
>>>>> @@ -109,8 +109,17 @@ acpi_hw_enable_runtime_gpe_block(struct
>>>>> acpi_gpe_xrupt_info *gpe_xrupt_info,
>>>> CONFIG_PCI is a Linux-ism. We should stay with the OS-independent
>>>> nature of ACPICA. Please use ACPI_PCI_CONFIGURED and put it above
>> the comment like so:
>>>>
>>>> #ifdef ACPI_PCI_CONFIGURED
>>>
>>> Thanks for the feedback. My search for ACPI_PCI_CONFIGURED returned
>> nothing.
>>>
>>> git grep ACPI_PCI_CONFIGURED
>>>
>>> @Rafael,
>>>
>>> How do you want to handle this?
>>
>> I think what Eric suggested is effectively to introduce a new ACPICA symbol.
>> Erik?
> 
> Yes, that's correct and you can add something like
> 
> #ifdef CONFIG_PCI
> #define ACPI_PCI_CONFIGURED
> #endif
> 
> in include/linux/platform/aclinux.h to enable it.
> 

OK. Let me rework this and test.