linux-kernel - Re: [PATCH v2 1/7] integrity: Define a trusted platform keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <871s6mffib.fsf@morokweng.localdomain>
Date:   Wed, 12 Dec 2018 22:15:56 -0200
From:   Thiago Jung Bauermann <bauerman@...ux.ibm.com>
To:     Nayna Jain <nayna@...ux.ibm.com>
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, zohar@...ux.ibm.com,
        dhowells@...hat.com, jforbes@...hat.com,
        seth.forshee@...onical.com, kexec@...ts.infradead.org,
        keyrings@...r.kernel.org, vgoyal@...hat.com, ebiederm@...ssion.com,
        mpe@...erman.id.au
Subject: Re: [PATCH v2 1/7] integrity: Define a trusted platform keyring


Nayna Jain <nayna@...ux.ibm.com> writes:

> On secure boot enabled systems, a verified kernel may need to kexec
> additional kernels. For example, it may be used as a bootloader needing
> to kexec a target kernel or it may need to kexec a crashdump kernel. In
> such cases, it may want to verify the signature of the next kernel
> image.
>
> It is further possible that the kernel image is signed with third party
> keys which are stored as platform or firmware keys in the 'db' variable.
> The kernel, however, can not directly verify these platform keys, and an
> administrator may therefore not want to trust them for arbitrary usage.
> In order to differentiate platform keys from other keys and provide the
> necessary separation of trust, the kernel needs an additional keyring to
> store platform keys.
>
> This patch creates the new keyring called ".platform" to isolate keys
> provided by platform from keys by kernel. These keys are used to
> facilitate signature verification during kexec. Since the scope of this
> keyring is only the platform/firmware keys, it cannot be updated from
> userspace.
>
> This keyring can be enabled by setting CONFIG_INTEGRITY_PLATFORM_KEYRING.
>
> Signed-off-by: Nayna Jain <nayna@...ux.ibm.com>
> Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
> Acked-by: Serge Hallyn <serge@...lyn.com>
> ---
>  security/integrity/Kconfig                         | 11 +++++
>  security/integrity/Makefile                        |  1 +
>  security/integrity/digsig.c                        | 48 +++++++++++++++-------
>  security/integrity/integrity.h                     |  3 +-
>  .../integrity/platform_certs/platform_keyring.c    | 35 ++++++++++++++++
>  5 files changed, 83 insertions(+), 15 deletions(-)
>  create mode 100644 security/integrity/platform_certs/platform_keyring.c

Reviewed-by: Thiago Jung Bauermann <bauerman@...ux.ibm.com>

-- 
Thiago Jung Bauermann
IBM Linux Technology Center