linux-kernel - Re: [PATCH] ARC: fix __ffs return value to avoid build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Dec 2018 18:23:18 +0000
From:   Vineet Gupta <vineet.gupta1@...opsys.com>
To:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Alexey Brodkin" <alexey.brodkin@...opsys.com>
Subject: Re: [PATCH] ARC: fix __ffs return value to avoid build warnings

On 12/13/18 7:43 AM, Eugeniy Paltsev wrote:
> Change __ffs return value from 'int' to 'unsigned long' as it
> is done in other implementations (like asm-generic, x86, etc...)
> to avoid build-time warnings in places where type is strictly
> checked.
>
> As __ffs may return values in [0-31] interval changing return
> type to unsigned is valid.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>

Can you please paste a couple of lines of offending output !

-Vineet