linux-kernel - Re: [PATCH] clk: qcom: Leave mmss noc on for 8998

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <154472978059.19322.5895645487468845661@swboyd.mtv.corp.google.com>
Date:   Thu, 13 Dec 2018 11:36:20 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>, andy.gross@...aro.org,
        david.brown@...aro.org, mturquette@...libre.com
Cc:     bjorn.andersson@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        marc.w.gonzalez@...e.fr, Jeffrey Hugo <jhugo@...eaurora.org>
Subject: Re: [PATCH] clk: qcom: Leave mmss noc on for 8998

Quoting Jeffrey Hugo (2018-12-13 08:59:30)
> Similar to other qcom targets, gcc_mmss_noc_cfg_ahb_clk should not be
> disabled.  Any mmss access depends on this clock, and its been observed
> that enabling mmssnoc_axi_rpm_clk with rpmcc results in an implicit
> access to mmss and will crash the system if gcc_mmss_noc_cfg_ahb_clk is
> disabled.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> ---
>  drivers/clk/qcom/gcc-msm8998.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index 4b75a09..b371308 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2014,6 +2014,7 @@ enum {
>                 .hw.init = &(struct clk_init_data){
>                         .name = "gcc_mmss_noc_cfg_ahb_clk",
>                         .ops = &clk_branch2_ops,
> +                       .flags = CLK_IGNORE_UNUSED,

It should be marked as CLK_IS_CRITICAL and a comment should be added to
the code indicating why it's critical.