linux-kernel - Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181213195923.GL2746@sasha-vm>
Date:   Thu, 13 Dec 2018 14:59:23 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     "'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        "'devel@...uxdriverproject.org'" <devel@...uxdriverproject.org>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        "'apw@...onical.com'" <apw@...onical.com>,
        vkuznets <vkuznets@...hat.com>,
        "'olaf@...fle.de'" <olaf@...fle.de>,
        "'jasowang@...hat.com'" <jasowang@...hat.com>,
        Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for
 unopened channels

On Thu, Dec 13, 2018 at 04:35:43PM +0000, Dexuan Cui wrote:
>
>Before 98f4c651762c, we returned zeros for unopened channels.
>With 98f4c651762c, we started to return random on-stack values.
>
>We'd better return -EINVAL instead.
>
>Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to dev_groups")
>Cc: stable@...r.kernel.org
>Cc: K. Y. Srinivasan <kys@...rosoft.com>
>Cc: Haiyang Zhang <haiyangz@...rosoft.com>
>Cc: Stephen Hemminger <sthemmin@...rosoft.com>
>Signed-off-by: Dexuan Cui <decui@...rosoft.com>

Queued up, thank you.

--
Thanks,
Sasha