linux-kernel - Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44ffbb80-37ab-b597-459b-1037f42d726d@allwinnertech.com>
Date:   Thu, 13 Dec 2018 12:39:05 +0800
From:   廖威雄 <liaoweixiong@...winnertech.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

In fast, there is no any failure while building or configuring on the 
newest codes.

The patch of commit 58eb5b670747 ("pstore: fix crypto dependencies") 
makes the pstore itself select the crypto core if PSTORE_COMPRESS is 
set. This fixes the dependence bug at all in my tests.
But this patch also turns the sub-options from 'bool' into 'tristate'. 
It's ok, but makes sub-options different between deflate, lzo, lz4, 
lz4hc and 842, zstd. So, my patch just keeps them in line.
How about to make all these sub-options as 'bool'? These compressions 
are just  function options but not module.  Otherwise, it's not about 
fixing crypto dependencies.

在 2018年12月13日 02:43, Kees Cook 写道:
> On Wed, Dec 12, 2018 at 12:24 AM liaoweixiong
> <liaoweixiong@...winnertech.com> wrote:
>>
>> Reference to commit 58eb5b670747 ("pstore: fix crypto dependencies"),
>> which fixed crypto dependencies of deflate, lzo, lz4 and lz4hc
>> compression, but omitted 842 and newer compression zstd from
>> commit 1021bcf44d0e ("pstore: add zstd compression support")
>>
>> Signed-off-by: liaoweixiong <liaoweixiong@...winnertech.com>
> 
> Were you seeing build or config failures without this patch?
> 
> -Kees
> 
>> ---
>>   fs/pstore/Kconfig | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
>> index 0d19d19..7068f45 100644
>> --- a/fs/pstore/Kconfig
>> +++ b/fs/pstore/Kconfig
>> @@ -44,14 +44,14 @@ config PSTORE_LZ4HC_COMPRESS
>>            This option enables LZ4HC (high compression) mode algorithm.
>>
>>   config PSTORE_842_COMPRESS
>> -       bool "842 compression"
>> +       tristate "842 compression"
>>          depends on PSTORE
>>          select CRYPTO_842
>>          help
>>            This option enables 842 compression algorithm support.
>>
>>   config PSTORE_ZSTD_COMPRESS
>> -       bool "zstd compression"
>> +       tristate "zstd compression"
>>          depends on PSTORE
>>          select CRYPTO_ZSTD
>>          help
>> --
>> 1.9.1
>>
> 
>