linux-kernel - Re: [PATCH] ASoC: simple-card: Dereference pointer for memcpy sizeof in asoc_simple_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   13 Dec 2018 14:07:42 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: Dereference pointer for memcpy sizeof in asoc_simple_card_probe


Hi Nathan

> sound/soc/generic/simple-card.c:462:6: warning: argument to 'sizeof' in
> 'memcpy' call is the same pointer type 'struct asoc_simple_dai *' as the
> source; expected 'struct asoc_simple_dai' or an explicit length
> [-Wsizeof-pointer-memaccess]
>                                         sizeof(priv->dai_props->cpu_dai));
>                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/generic/simple-card.c:464:6: warning: argument to 'sizeof' in
> 'memcpy' call is the same pointer type 'struct asoc_simple_dai *' as the
> source; expected 'struct asoc_simple_dai' or an explicit length
> [-Wsizeof-pointer-memaccess]
>                                         sizeof(priv->dai_props->codec_dai));
>                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 warnings generated.
> 
> Commit 4fb7f4df49d3 ("ASoC: simple-card: use cpu/codec pointer on
> simple_dai_props") updated {cpu,codec}_dai to be pointers in struct
> simple_dai_props but didn't update these locations to dereference the
> pointers to get the proper size of their contents.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  sound/soc/generic/simple-card.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
> index 766123485d7c..d4738d3eb2f1 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -459,9 +459,9 @@ static int asoc_simple_card_probe(struct platform_device *pdev)
>  		dai_link->dai_fmt	= cinfo->daifmt;
>  		dai_link->init		= asoc_simple_card_dai_init;
>  		memcpy(&priv->dai_props->cpu_dai, &cinfo->cpu_dai,
> -					sizeof(priv->dai_props->cpu_dai));
> +					sizeof(*priv->dai_props->cpu_dai));
>  		memcpy(&priv->dai_props->codec_dai, &cinfo->codec_dai,
> -					sizeof(priv->dai_props->codec_dai));
> +					sizeof(*priv->dai_props->codec_dai));
>  	}

Ahh.. yes, simple-card is supporting non DT case, too.
Thank you for your patch.
But, I think "&priv->dai_props->codec_dai" need to fix, too.
And it needs to point cpu_dai/codec_dai.
Thank you for pointing it. I will fixup and post with your name.

Best regards
---
Kuninori Morimoto