linux-kernel - Re: [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1544660301.3956.3.camel@linux.ibm.com>
Date:   Wed, 12 Dec 2018 19:18:21 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, dhowells@...hat.com,
        jforbes@...hat.com, seth.forshee@...onical.com,
        kexec@...ts.infradead.org, keyrings@...r.kernel.org,
        vgoyal@...hat.com, ebiederm@...ssion.com, mpe@...erman.id.au
Subject: Re: [PATCH v2 7/7] ima: Support platform keyring for kernel
 appraisal

On Wed, 2018-12-12 at 16:14 -0200, Thiago Jung Bauermann wrote:
[snip]

> Subject: [PATCH] ima: Only use the platform keyring if it's enabled
> 
> Signed-off-by: Thiago Jung Bauermann <bauerman@...ux.ibm.com>

Good catch!  Thanks.

Mimi

> ---
>  security/integrity/ima/ima_appraise.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index e8f520450895..f6ac405daabb 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -297,7 +297,8 @@ int ima_appraise_measurement(enum ima_hooks func,
>  			status = INTEGRITY_UNKNOWN;
>  			break;
>  		}
> -		if (rc && func == KEXEC_KERNEL_CHECK)
> +		if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
> +		    func == KEXEC_KERNEL_CHECK)
>  			rc = integrity_digsig_verify(INTEGRITY_KEYRING_PLATFORM,
>  						     (const char *)xattr_value,
>  						     xattr_len,