linux-kernel - Re: [PATCH] staging: erofs: Add a blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c8c61ca-196c-af95-7211-4e504fc85e59@huawei.com>
Date:   Thu, 13 Dec 2018 18:34:20 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <gaoxiang25@...wei.com>,
        Sungkyung Kim <jotun9935@...il.com>
CC:     <gregkh@...uxfoundation.org>, <linux-erofs@...ts.ozlabs.org>,
        <linux-kernel@...r.kernel.org>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: erofs: Add a blank line after declarations

On 2018/12/13 9:51, Gao Xiang wrote:
> Hi Sungkyung,
> 
> On 2018/12/12 23:50, Sungkyung Kim wrote:
>> Fix a warning from checkpathch.pl: 'Missing a blank line after
>> declarations'
>>
>> Signed-off-by: Sungkyung Kim <jotun9935@...il.com>
>> ---
>>  drivers/staging/erofs/inode.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
>> index 04c61a9d7b76..82b6ad5badff 100644
>> --- a/drivers/staging/erofs/inode.c
>> +++ b/drivers/staging/erofs/inode.c
>> @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,
>>  	if (inode->i_state & I_NEW) {
>>  		int err;
>>  		struct erofs_vnode *vi = EROFS_V(inode);
>> +
> 
> Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
> 
> If not, could you have time check the other files? That is my personal thought, and
> I cc-ed the staging mailing list as well.

Agreed, it needs to check all files, and fix similar coding style issues in
one patch.

Thanks,

> 
> Thanks,
> Gao Xiang
> 
>>  		vi->nid = nid;
>>  
>>  		err = fill_inode(inode, isdir);
>>
> 
> .
>