linux-kernel - Re: [PATCH V2] kernel/hung_task.c: Force console verbose before panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181213115426.lmymctoawomzlkdo@pathway.suse.cz>
Date:   Thu, 13 Dec 2018 12:54:26 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     "Liu, Chuansheng" <chuansheng.liu@...el.com>
Cc:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "sergey.senozhatsky@...il.com" <sergey.senozhatsky@...il.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "dvyukov@...gle.com" <dvyukov@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] kernel/hung_task.c: Force console verbose before panic

On Thu 2018-12-13 01:51:22, Liu, Chuansheng wrote:
> Based on patch commit 401c636a0eeb ("kernel/hung_task.c:
> show all hung tasks before panic"), we could get the
> call stack of hung task.
> 
> However, if the console loglevel is not high, we still
> can not see the useful panic information in practice,
> and in most cases users don't set console loglevel to
> high level.
> 
> This patch is to force console verbose before system
> panic, so that the real useful information can be seen
> in the console, instead of being like the following,
> which doesn't have hung task information.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>

Makes sense and looks good to me:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr