linux-kernel - Re: use generic DMA mapping code in powerpc V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e109de27-f4af-147d-dc0e-067c8bafb29b@xenosoft.de>
Date:   Thu, 13 Dec 2018 14:34:49 +0100
From:   Christian Zigotzky <chzigotzky@...osoft.de>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-arch@...r.kernel.org,
        Darren Stevens <darren@...vens-zone.net>,
        linux-kernel@...r.kernel.org, Julian Margetson <runaway@...dw.ms>,
        linux-mm@...ck.org, iommu@...ts.linux-foundation.org,
        Paul Mackerras <paulus@...ba.org>,
        Olof Johansson <olof@...om.net>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: use generic DMA mapping code in powerpc V4

On 13 December 2018 at 12:25PM, Christoph Hellwig wrote:
> On Thu, Dec 13, 2018 at 12:19:26PM +0100, Christian Zigotzky wrote:
>> I tried it again but I get the following error message:
>>
>> MODPOST vmlinux.o
>> arch/powerpc/kernel/dma-iommu.o: In function `.dma_iommu_get_required_mask':
>> (.text+0x274): undefined reference to `.dma_direct_get_required_mask'
>> make: *** [vmlinux] Error 1
> Sorry, you need this one liner before all the patches posted last time:
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index d8819e3a1eb1..7e78c2798f2f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -154,6 +154,7 @@ config PPC
>   	select CLONE_BACKWARDS
>   	select DCACHE_WORD_ACCESS		if PPC64 && CPU_LITTLE_ENDIAN
>   	select DYNAMIC_FTRACE			if FUNCTION_TRACER
> +	select DMA_DIRECT_OPS
>   	select EDAC_ATOMIC_SCRUB
>   	select EDAC_SUPPORT
>   	select GENERIC_ATOMIC64			if PPC32
>
Thanks. Result: PASEMI onboard ethernet works and the X5000 (P5020 
board) boots with the patch '0001-get_required_mask.patch'.

-- Christian