linux-kernel - Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add McSPI DT nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Dec 2018 16:59:45 +0200
From:   Tero Kristo <t-kristo@...com>
To:     Vignesh R <vigneshr@...com>, Nishanth Menon <nm@...com>
CC:     Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add McSPI DT nodes

On 09/12/2018 12:22, Vignesh R wrote:
> There are 3 instances of McSPI in MCU domain and 4 instances in Main domain.
> Add DT nodes for all McSPI instances present on AM654 SoC.
> 
> Signed-off-by: Vignesh R <vigneshr@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 52 ++++++++++++++++++++++++
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi  | 30 ++++++++++++++
>   2 files changed, 82 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 0a0a8fc5df64..6c71e67b8988 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -138,4 +138,56 @@
>   		clocks = <&k3_clks 39 0>;
>   		clock-names = "fck";
>   	};
> +
> +	main_spi0: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";

WARNING: DT compatible string "ti,am654-mcspi" appears un-documented -- 
check ../../Documentation/devicetree/bindings/
#63: FILE: arch/arm64/boot/dts/ti/k3-am65-main.dtsi:143:
+		compatible = "ti,am654-mcspi","ti,omap4-mcspi";

Same for the rest of the nodes.

Did you forget documentation part?

-Tero

> +		reg = <0x0 0x2100000 0x0 0x400>;
> +		interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 137 1>;
> +		power-domains = <&k3_pds 137>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
> +	main_spi1: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x2110000 0x0 0x400>;
> +		interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 138 1>;
> +		power-domains = <&k3_pds 138>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		assigned-clocks = <&k3_clks 137 1>;
> +		assigned-clock-rates = <48000000>;
> +	};
> +
> +	main_spi2: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x2120000 0x0 0x400>;
> +		interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 139 1>;
> +		power-domains = <&k3_pds 139>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
> +	main_spi3: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x2130000 0x0 0x400>;
> +		interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 140 1>;
> +		power-domains = <&k3_pds 140>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
> +	main_spi4: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x2140000 0x0 0x400>;
> +		interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 141 1>;
> +		power-domains = <&k3_pds 141>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
>   };
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 1fd027748e1f..1aeae52fb239 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -26,4 +26,34 @@
>   		clocks = <&k3_clks 114 1>;
>   		power-domains = <&k3_pds 114>;
>   	};
> +
> +	mcu_spi0: spi@...00000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x40300000 0x0 0x400>;
> +		interrupts = <GIC_SPI 560 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 142 1>;
> +		power-domains = <&k3_pds 142>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
> +	mcu_spi1: spi@...10000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x40310000 0x0 0x400>;
> +		interrupts = <GIC_SPI 561 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 143 1>;
> +		power-domains = <&k3_pds 143>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
> +	mcu_spi2: spi@...20000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x0 0x40320000 0x0 0x400>;
> +		interrupts = <GIC_SPI 562 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&k3_clks 144 1>;
> +		power-domains = <&k3_pds 144>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
>   };
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki